feat: mark action as explicitly accepting promises #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while typescript allows passing in `() => Promise<void>` as a callback for `() => void`, typescript-eslint catches those as `Promise returned in function argument where a void return was expected.eslint@typescript-eslint/no-misused-promises` (in its type-checking rules) this change allows passing in async functions to `action()`, knowing the returned promise by `parseAsync()` will be handled by the caller.
|
I expected this would get applied to Commander too, but it is already there: https://github.com/tj/commander.js/blob/8b03ab75b5431fd2d58a24b842ba088d621f12dc/typings/index.d.ts#L498 The |
shadowspawn
added
the
pending release
This was referenced Feb 28, 2023
Closed
shadowspawn
removed
the
pending release
|
Released in v10.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while typescript allows passing in
() => Promise<void>as a callback for() => void, typescript-eslint catches those asPromise returned in function argument where a void return was expected.eslint@typescript-eslint/no-misused-promises(in its type-checking rules)this change allows passing in async functions to
action(), knowing the returned promise byparseAsync()will be handled by the caller.