HKG CAN FD: potentially get VIN without OBD port on some platforms #31348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to instead merge this without the HDA2 support, as that can pretty significantly slow down cars where we can't/don't get the VIN, plus I want to see what other cars this can possibly work on. Getting users to test is slow and this has no timing impact! |
sshane
changed the title
sshane
changed the title
1 task
sshane
added a commit
that referenced
this pull request
Feb 15, 2024
Added camera addr instead of cluster on accident here: #31348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this can significantly increase time to get VIN on cars where we don't/can't, and the fact that we already know this doesn't work on the GV80, going to close