-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asb): Retry locking Monero #1731
feat(asb): Retry locking Monero #1731
Conversation
Probably better to use the ExponentialBackoff library instead of implementing it yourself. I'd say we start off retrying every 5seconds or so and stop at a maximum delay of 5 minutes. |
88479c6
to
8ceb59f
Compare
FYI this reset your branch to match origin/master while retaining the changes from your commit. git reset --hard origin/master
git cherry-pick 88479c67cc7b9d47ead6cbe4aee5a945771b764f |
735b517
to
8001d60
Compare
I worked around the confusing type situation by letting the type inference to the job |
I tested it manually. LGTM! |
LGTM too, but I haven't tested it. |
This attempts to close #1726.
Instead of giving up on locking the XMR when it fails once, we retry a limited number of times, always with an exponentially bigger delay.