Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asb): Retry locking Monero #1731

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

Einliterflasche
Copy link
Contributor

This attempts to close #1726.

Instead of giving up on locking the XMR when it fails once, we retry a limited number of times, always with an exponentially bigger delay.

@binarybaron
Copy link
Collaborator

binarybaron commented Jul 25, 2024

Probably better to use the ExponentialBackoff library instead of implementing it yourself. I'd say we start off retrying every 5seconds or so and stop at a maximum delay of 5 minutes.

@binarybaron
Copy link
Collaborator

FYI this reset your branch to match origin/master while retaining the changes from your commit.

git reset --hard origin/master
git cherry-pick 88479c67cc7b9d47ead6cbe4aee5a945771b764f

@Einliterflasche
Copy link
Contributor Author

I worked around the confusing type situation by letting the type inference to the job

@binarybaron binarybaron changed the title Retry xmr lock feat(asb): Retry locking Monero Jul 25, 2024
@binarybaron binarybaron marked this pull request as ready for review July 25, 2024 19:50
@binarybaron binarybaron requested a review from delta1 July 25, 2024 19:50
@binarybaron
Copy link
Collaborator

I tested it manually. LGTM!

@Einliterflasche
Copy link
Contributor Author

LGTM too, but I haven't tested it.

@binarybaron binarybaron merged commit 2fe4287 into comit-network:master Jul 25, 2024
29 checks passed
@Einliterflasche Einliterflasche deleted the retry-xmr-lock branch July 26, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry locking of Monero if fails on first try
2 participants