test: Add giftaid submit and update ERP tests #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyEPhipps
previously approved these changes
Jul 4, 2024
AndyEPhipps
reviewed
Jul 4, 2024
| ]); | ||
|
|
||
| // Check for the thank you message to confirm successful submission | ||
| await expect(page.locator('div > h1')).toHaveText(`Thank you, ${contactInfo.firstName}!`); |
There was a problem hiding this comment.
Just a general thought (not specifically for this test or repo), but it might be good to use more specific selectors, something like div.success-wrapper--inner h1 or even div.success-wrapper--inner h1:first-child, just to make things as non-brittle as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-3411