ENG-3255: 'Update' form updates - remove transactionID

[AndyEPhipps]

Updates purely on the /update form; as per https://comicrelief.atlassian.net/browse/ENG-3255

• Remove transaction ID field, validation and any other config that relates to it

• Update and bring in improved PCLU that clarifies the UK-centricity of the postcode validation

• make Email Address mandatory

• Add a new optional Mobile Number field, but with copy to stress that if the donor made their donation via SMS we need it - NB they cannot donate via a non-UK mobile number

[AndyEPhipps]

@KrupaPammi, additional bit of a context from the main ticket:

Andy Phipps:
While we’re removing the “manual” field from the user flow, do we want to do away with EVERYTHING transactionID related?

We currently have functionality to pass a transactionID to the application as a URL param (presumably dynamically set in some email template somewhere) - are we sacking this all off?

Corin Ashwell:
yep, get rid of it completely.

Andy Phipps:
Sorry, one other thing; there’s also functionality in the /update form using the URL param as a trigger to then ask the user how they made the donation (SMS, Online, Call centre). Not sure why it’s only in this specific context but 🤷

Seems like a step backwards to remove this data source completely; probs best to leave it in for all update journeys aye?

Corin Ashwell:
In the old days this form was principally so that we could send letters to call centre donors after NOTV and if they needed to amend their Gift Aid status they could use this page. I am guessing the type of donation was so that we could use that to match to their donation data in SSV. maybe.

If you can leave it in without any trouble maybe that’s a good idea, but all the backend will do now is collect the user details and pass those into ERP/CRM/data lake/wherever

So basically, we show the donationType checkboxes for all /Update journeys now, and I've updated the tests to reflect that.

[AndyEPhipps]

Agreed that for the Gift Aid Update form we will:

• remove Transaction ID field completely;

• make Email Address mandatory;

• make Mobile Number an optional field but with copy to stress that if the donor made their donation via SMS we need it - NB they cannot donate via a non-UK mobile number

• improve copy on postal address lookup so that overseas addresses are easy to understand

Doh, sorry - realised I missed a few other bits from the original PR - will re-assign once I'm done.

[AndyEPhipps]

Sorry for the big ugly diff to review, gang.

It's worth noting that the donationType radiobutton up top:

... used to be only shown when the transactionID was passed as a URL param (from a personalised email). Rather than 100% removing this data source along with the transactionID itself, Corin and I elected that we'd best keep that radiobutton in for all /update contexts, useful data and all.

Testable here: https://deploy-preview-427--giftaid-react.netlify.app/update

[AndyEPhipps]

@KrupaPammi if you're able to prioritise this this morning, I'd appreciate it - we're having to sync the B/E and F/E deploys, and have 3pm pencilled-in to do so.

[KrupaPammi]

@AndyEPhipps sure, will do it now.

[AndyEPhipps]

Whoops 😬

[KrupaPammi]

Hi @AndyEPhipps, I just finished testing this, works as expected. I've updated a couple of tests.

[AndyEPhipps]

Thanks very much @KrupaPammi; appreciate the speediness!