Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/startup-script: Feature to avoid package installation errors when installing custom nodes. #856

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

ltdrdata
Copy link
Collaborator

@ltdrdata ltdrdata commented Jul 9, 2023

Currently, in ComfyUI-Manager, automatic installation of dependencies is performed when installing custom nodes. However, this can lead to module conflicts or failure to install due to file locking issues, especially in Windows environments.

To address this problem, a solution has been implemented where the imports are minimized at the top of main.py, allowing the install script to run in an environment with minimal imports.

@ltdrdata
Copy link
Collaborator Author

ltdrdata commented Jul 9, 2023

modified

@comfyanonymous comfyanonymous merged commit 99abcbe into comfyanonymous:master Jul 11, 2023
@ltdrdata ltdrdata deleted the feature/startup-script branch July 11, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants