Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disable-compres-response-body cli args; add compress middleware; #6672

Merged
merged 1 commit into from
Feb 2, 2025
Merged

add disable-compres-response-body cli args; add compress middleware; #6672

merged 1 commit into from
Feb 2, 2025
+19 −1

Conversation

KarryCharon
Copy link
Contributor

No description provided.

@comfyanonymous comfyanonymous merged commit 24d6871 into comfyanonymous:master Feb 2, 2025
5 checks passed
@bigcat88 bigcat88 mentioned this pull request Feb 3, 2025
Merged
bigcat88 added a commit to Visionatrix/Visionatrix that referenced this pull request Feb 3, 2025
@bigcat88
disable ComfyUI response compression (#299)
0e5c2b3 
I don't quite understand why they put everything that can be easily and
professionally done with reverse proxies into ComfyUI, but that's their
choice.

We just disable this feature completely, as it doesn't needed from our
point of view.

Reference: comfyanonymous/ComfyUI#6672

Signed-off-by: bigcat88 <[email protected]>
@LukeG89
Copy link

LukeG89 commented Feb 3, 2025

@comfyanonymous This PR triggers a user warning after starting the server:

Starting server

To see the GUI go to: http://127.0.0.1:8188
FETCH DATA from: E:\ComfyUI\custom_nodes\comfyui-manager\extension-node-map.json [DONE]
E:\python_embeded\Lib\site-packages\aiohttp\web_response.py:804: UserWarning: Synchronous compression of large response bodies (1858146 bytes) might block the async event loop. Consider providing a custom value to zlib_executor_size/zlib_executor response properties or disabling compression on it.
  warnings.warn(

@KarryCharon
Copy link
Contributor Author

@comfyanonymous For the warning above: KarryCharon@49b48a6

@LukeG89 LukeG89 mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarryCharon @LukeG89 @comfyanonymous