Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Hook Keyframes Interp. Node #5896

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

Kosinkadink
Copy link
Collaborator

Working on a tutorial for hooks, I realized I should have ported this node in from ADE earlier. It's a built-in way of generating multiple keyframes that will also help me write the tutorial.

@comfyanonymous comfyanonymous merged commit f7695b5 into master Dec 4, 2024
6 checks passed
@comfyanonymous comfyanonymous deleted the add_kf_interp branch December 4, 2024 02:06
@andreszs
Copy link

andreszs commented Dec 19, 2024

This node is superb for lora scheduling and I've posted a simplified workflow for using it here. These new nodes render obsolete all the unreliable, third-party scheduling nodes as well, which is great news.

That being said, understanding the node's values would be much easier by means of a strength curve canvas, like the one shown in my blog which was created using Chat GPT data analysis+Google Sheets. I'd like to update your node to draw such canvas to reflect the node's settings on the fly.

This would require a new create-hook-keyframes-interp.js file to deal with the canvas drawing and updating. Where do you suggest to create this JS file? was thinking about the web/assets folder. Your advice will be greatly appreciated.

For reference, I've created some masking nodes that are now part of the Impact Pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants