Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPIK-194 Sanity end-to-end tests - UI tests #357

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

AndreiCautisanu
Copy link
Contributor

Details

Setup a class structure for each page in the project to be expanded upon in the future as we add more flows and checks. Will try and keep all interactions with the pages themselves isolated in the Page classes to keep tests compact and readable.

Added tests to check creation of Traces and Spans via SDK, everything seems to work, will add the rest and re-test for any flakiness.

@ferc you can try and run these yourselves if you checkout the project branch, have python and Opik installed locally and do

cd tests/end_to_end
export PYTHONPATH='.'
pip install -r test_requirements.txt
pytest -s application_sanity/test_sanity.py --browser chromium --base-url http://localhost:5173 --setup-show --headed

Otherwise you can find a successful run on Actions here: https://github.com/comet-ml/opik/actions/runs/11216925985

Next commits

  • small refactors to tests now that they work
  • add tests for tags/metadata/scores
  • add tests for database
  • add tests for experiments

Don't merge until I've added the above and established when and how to run them at first, will add everything else and do a clean-up shortly

@AndreiCautisanu AndreiCautisanu requested a review from a team as a code owner October 7, 2024 14:48
Copy link
Collaborator

@ferc ferc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ferc ferc merged commit 3749d11 into main Oct 8, 2024
@ferc ferc deleted the andrei/opik-194/e2e-tests-playwright branch October 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants