[OPIK-148] Implement batching for feedback scores, update and add new tests #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japdubengsub
previously approved these changes
Jan 10, 2025
japdubengsub
approved these changes
Jan 10, 2025
alexkuzmik
deleted the
OPIK-148-sdk-implement-batching-span-trace-feedback-scores
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Feedback scores for spans and traces can now be batched in the background.
Implementation detail note: since SDK already had methods for logging batches of scores, current PR introduced merging those batches into a bigger one. When this big batch is released - it get's a flag
supports_batching=Falseso the streamer knows its a batch that shouldn't be merged with anything else.Testing
New unit tests have been added, slightly updated existing e2e tests.
Documentation
No documentation changes needed.