-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-593] OnlineScoring sampling and preparing traces for Automation Rules #1002
Conversation
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluator.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorCriteria.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorLlmAsJudge.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorLlmAsJudge.java
Outdated
Show resolved
Hide resolved
...backend/src/main/java/com/comet/opik/api/resources/v1/events/OnlineScoringEventListener.java
Outdated
Show resolved
Hide resolved
...backend/src/main/java/com/comet/opik/api/resources/v1/events/OnlineScoringEventListener.java
Outdated
Show resolved
Hide resolved
...backend/src/main/java/com/comet/opik/api/resources/v1/events/OnlineScoringEventListener.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorUpdate.java
Outdated
Show resolved
Hide resolved
...backend/src/main/java/com/comet/opik/api/resources/v1/events/OnlineScoringEventListener.java
Outdated
Show resolved
Hide resolved
...backend/src/main/java/com/comet/opik/api/resources/v1/events/OnlineScoringEventListener.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorLlmAsJudge.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorLlmAsJudge.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/AutomationRuleEvaluatorLlmAsJudge.java
Show resolved
Hide resolved
...ik-backend/src/main/java/com/comet/opik/api/resources/v1/events/LlmAsJudgeMessageRender.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/AutomationRuleEvaluatorDAO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but feel free to address in the next PR
Already in, let's do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Details
Online Scoring now listens for new Traces created - when a new trace or batch arrives, it checks for existent rules, samples the traces and prepares an AI Proxy request (which is part of the next ticket).
This PR also replaces the AutomationRuleEvaluatorLlmAsJudge
code
field from a JsonNode into a proper definition now we understand better what should be the payload request.Issues
OPIK-592
OPIK-593
Testing
Documentation