Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-593] OnlineScoring sampling and preparing traces for Automation Rules #1002

Merged
merged 15 commits into from
Jan 8, 2025

Conversation

ldaugusto
Copy link
Contributor

@ldaugusto ldaugusto commented Jan 8, 2025

Details

Online Scoring now listens for new Traces created - when a new trace or batch arrives, it checks for existent rules, samples the traces and prepares an AI Proxy request (which is part of the next ticket).

This PR also replaces the AutomationRuleEvaluatorLlmAsJudge code field from a JsonNode into a proper definition now we understand better what should be the payload request.

Issues

OPIK-592
OPIK-593

Testing

Documentation

@ldaugusto ldaugusto requested a review from thiagohora January 8, 2025 13:04
@ldaugusto ldaugusto requested a review from a team as a code owner January 8, 2025 13:04
thiagohora
thiagohora previously approved these changes Jan 8, 2025
Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but feel free to address in the next PR

@ldaugusto
Copy link
Contributor Author

Some minor comments but feel free to address in the next PR

Already in, let's do it!

Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ldaugusto ldaugusto merged commit 9ae31b9 into main Jan 8, 2025
8 checks passed
@ldaugusto ldaugusto deleted the daniel/online_scoring_trigger_by_trace branch January 8, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants