Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Codeartifact contrib module #985

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Add AWS Codeartifact contrib module #985

merged 4 commits into from
Nov 3, 2020

Conversation

realbrianstern
Copy link
Contributor

This allows Mill projects to deploy to AWS Codeartifact. It functions similarly to the Artifactory PublishModule. Its credentials value is a Codeartifact auth token.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's missing here is the actual inclusion of the codeartifact module in the build.sc.

@realbrianstern
Copy link
Contributor Author

Ah of course! Just added it

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lefou lefou merged commit 3e4d9aa into com-lihaoyi:master Nov 3, 2020
@lefou
Copy link
Member

lefou commented Nov 3, 2020

Thank you for this contribution!

@lefou lefou added this to the after 0.8.0 milestone Nov 3, 2020
@realbrianstern realbrianstern deleted the codeartifact-contrib branch November 4, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants