Introduce named test traits and some scalalib reorganization #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
force-pushed
the
cleanup-scalalib
branch
from
d49a3d0 to
1a6b3cc
Compare
lefou
changed the title
lefou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deriving from
ScalaModuleand it's friends, it's sometime hard to properly customize tests. E.g. When mixing traits that all customizes tests you can't pick the rightsuper.Testsnor can you merge two differentsuper.Tests. Therefore this PR gives each test trait a unique name. Also I moved some traits into their own files, to make code navigation easier.