Resolve Mill build source dependencies

[joan38]

No description provided.

[joan38]

Ping @lefou @lihaoyi

[joan38]

We used to not resolve source dependencies for the Mill build dependencies. Which made code navigation hard since all we could see were the signature only.

[joan38]

Now we get the source files for the build dependencies filtering with isSourceJar.

[joan38]

We are filtering out the source jars here since they are loaded in buildTargetDependencySources.

[lefou]

Can you please describe what the issue is and how this PR solves it.

[joan38]

Sure. In my build.sc if I want to know what transitiveIvyDeps does I will typically jump to definition (cmd+click) and see the implementation to answer most of my questions. This is what I did to answer this question on Gitter:

  /**
    * The transitive ivy dependencies of this module and all it's upstream modules
    */
  def transitiveIvyDeps: T[Agg[Dep]] = T{
    ivyDeps() ++ T.traverse(moduleDeps)(_.transitiveIvyDeps)().flatten
  }

But with the current state of BSP it looks like this:

  @mill.moduledefs.Scaladoc(value = """/**
    * The transitive ivy dependencies of this module and all it's upstream modules
    */""")
  def transitiveIvyDeps : mill.T[mill.api.Loose.Agg[mill.scalalib.Dep]] = { /* compiled code */ }

Because I don't have the sources loaded in my IDE, so the IDE decompiled the class files.

With this change, it loads the source jars of mill build dependencies accordingly.

[lefou]

Looks good to me.

[joan38]

Thanks @lefou