Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docjar context classloader conflict in scala 3 #4331

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 15, 2025

Fixes #4316

This isn't a general solution to make context classloaders behave properly in the presence of long-lived worker objects instantiated from classloaders. Rather, we just hard-code support in the Scala3 docjar callsite to properly set the context classloader there, since these context-classloader-sensitive pieces of code are pretty rare in Mill and so we can just deal with them individually as they pop up

CC @joan38

@lihaoyi lihaoyi marked this pull request as ready for review January 15, 2025 05:15
@lihaoyi lihaoyi merged commit 2a40b17 into com-lihaoyi:main Jan 15, 2025
35 of 37 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency clash with Scala 3 on jackson while generating scaladoc with docJar
2 participants