Fix docjar context classloader conflict in scala 3 #4331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4316
This isn't a general solution to make context classloaders behave properly in the presence of long-lived worker objects instantiated from classloaders. Rather, we just hard-code support in the Scala3 docjar callsite to properly set the context classloader there, since these context-classloader-sensitive pieces of code are pretty rare in Mill and so we can just deal with them individually as they pop up
CC @joan38