Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-module BSP tests #4262

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Conversation

alexarchambault
Copy link
Collaborator

This PR adds multi-module non-regression tests of the BSP support. This is helpful for #4145, that touches some BSP things in MillBuildServer.

@lefou
Copy link
Member

lefou commented Jan 8, 2025

I find it hard to read those dependency tests in general. There is often a motivation for a test, what should be tested, why were specific dependencies used and what is the significant part of the comparison? Maybe, you can add one or two lines of comments, so the later dev understands the test better?

@alexarchambault
Copy link
Collaborator Author

I find it hard to read those dependency tests in general. There is often a motivation for a test, what should be tested, why were specific dependencies used and what is the significant part of the comparison? Maybe, you can add one or two lines of comments, so the later dev understands the test better?

Sure, I just added some comments

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lefou lefou merged commit c9e0b69 into com-lihaoyi:main Jan 8, 2025
26 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 8, 2025
@alexarchambault alexarchambault deleted the more-bsp-tests branch January 8, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants