-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul transitive module handling in dependency resolution #4145
Merged
alexarchambault
merged 47 commits into
com-lihaoyi:main
from
alexarchambault:java-module-cs-project
Jan 16, 2025
+782
−247
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
95f49f9
Overhaul transitive module handling in dep resolution
alexarchambault a561284
fixes
alexarchambault 9434d99
Update coursier to 2.1.22
alexarchambault ca347cc
Temporary - drop resolveFilters
alexarchambault b1eff1c
Fix
alexarchambault 24714ed
Get rid of resolveFilter stuff
alexarchambault e1c1daa
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 275f54d
Missing bits from #4162
alexarchambault 5c90bb0
Fix bin compat
alexarchambault 1a8a3d2
add docs, tweak things
alexarchambault c6c8a7e
Add doc, plus fixes / guards
alexarchambault 191bf54
Merge branch 'main' into pr/java-module-cs-project
alexarchambault d9195df
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 6f39c72
Tweaking
alexarchambault 31f610d
Update BspServerTests test data
alexarchambault 4f293a3
Merge branch 'main' into pr/java-module-cs-project
alexarchambault aa5e418
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 2098054
Cache test module overrides read attempts
alexarchambault feda739
Better error messages
alexarchambault b970a90
debug bootstrap job
alexarchambault e1c02eb
debug deadlock issue on CI
alexarchambault 8b8db3c
fixup
alexarchambault 9c2e634
fixup
alexarchambault 84d8a4d
debug
alexarchambault 10601aa
?
alexarchambault 222efe7
Revert "debug"
alexarchambault 90f93e9
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 1f46568
More debugging
alexarchambault 7ad6ff4
check
alexarchambault db7af84
other check
alexarchambault 8f8ecb0
Revert "check"
alexarchambault c5dc629
Tweaking
alexarchambault e1f5d8f
Don't change default stderr
alexarchambault a122015
last check
alexarchambault 30462a2
?
alexarchambault 5527736
Revert debug stuff
alexarchambault 847462b
fmt
alexarchambault b9ee650
Update BSP test snapshots
alexarchambault 4c0a06f
Merge branch 'main' into pr/java-module-cs-project
alexarchambault b5611cf
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 2c6b737
Tweak things / add comments
alexarchambault da17946
Fix version in new deprecation messages
alexarchambault 7ac0124
Fix new import order
alexarchambault 0d8d34d
Revert BSP benchmark change
alexarchambault 536d958
Copy comment
alexarchambault 685fb8d
Merge branch 'main' into pr/java-module-cs-project
alexarchambault 1ab71c9
Fix out-files test
alexarchambault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Copy comment
commit 536d958858a7bbde3c84af8873e08bf9cd051afa
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs is missing. What is this? How it differentiates to
repositoriesTask
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some. The internal in-memory repo with the coursier projects of Mill's modules is meant to go there.