Pass a classpath made for runtime to Kotlin JS linker #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
changed the title
jodersky
pushed a commit
to jodersky/mill
that referenced
this pull request
Jan 14, 2025
The current code passes a class path made for compile time to the Kotlin JS linker. While it's not a problem with the current main branch that doesn't really make a difference between compile and runtime class paths, this will be a problem with com-lihaoyi#4028, that can bring less JARs in `compileClasspath` (while all JARs will be around in runtime targets, like `resolvedRunIvyDeps`, like currently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code passes a class path made for compile time to the Kotlin JS linker. While it's not a problem with the current main branch that doesn't really make a difference between compile and runtime class paths, this will be a problem with #4028, that can bring less JARs in
compileClasspath(while all JARs will be around in runtime targets, likeresolvedRunIvyDeps, like currently)