-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace full-width prompt header with a variable-width-with-max prompt header #4014
Conversation
CC @lefou I think we discussed something like this before |
I don't need the dashes at all. Also I accidentally thought some time ago that you changed the progress logger to have the seconds before the task name and I really liked it. (Then I realized, I was looking at some evaluator command running anonymous tasks with with extra ticker output.) Nevertheless, If we move the timing between the progress and the task name, we could end up with a condensed consistent output: Before:
After (mocked):
|
For me I need some kind of dashes, otherwise i find the lack of separation makes it visually hard to distinguish log lines from prompt lines. The timing on the left thing is possible, but one issue is the timing string is variable width, from zero to four digits wide (to give an arbitrary upper limit). So either we would need to reserve a pretty wide gutter, or we would have un-aligned task selectors, or we would have task selectors moving left and right as the longest lived tasks complete. Might be possible to find a compromise but may need more thought |
We could use a |
The previous full-width prompt header looks really weird on wide screens, even a full-width laptop screen is enough to make it awkward. This PR replaces it with a variable-width prompt header with some heuristics for shortening the
=
bars and the title text as necessary.Covered by existing tests, added some more thorough tests in
PromptLoggerUtilTests.scala
to exercise the edge cases in the new shortening heuristics