Update coursier to 2.1.18 and coursier-interface to 1.0.24 #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter using the former under-the-hood (in a hidden proguarded fashion)
This comment was marked as resolved.
This comment was marked as resolved.
alexarchambault
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
alexarchambault
force-pushed
the
coursier-2.1.17
branch
2 times, most recently
from
390809c to
544f319
Compare
Conflicts: build.mill
lihaoyi
reviewed
Nov 20, 2024
lihaoyi
pushed a commit
that referenced
this pull request
Nov 21, 2024
Needed for #3950. It's running into a [scaladoc bug](scala/bug#10028), and would need to exclude an internal dependency of coursier from the class path passed to scaladoc. Once merged, Mill would need to be rebootstrapped on the latest nightly version, and #3950 would override `UnidocModule#unidocCompileClasspath` to exclude the JAR of coursier/dependency from it.
lefou
reviewed
Nov 21, 2024
lefou
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coursier
2.1.18takes Maven "BOMs" better into account, which can sometimes significantly change the versions (or even the dependencies) selected by coursier (see also the2.1.17release notes).#3949 offers a way to disable the new way of processing BOMs, if ever that's needed, with
coursier-interface is bumped along the way just in case. Its
1.0.24version uses coursier2.1.18under-the-hood (in a hidden proguarded fashion).