Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for import $meta and import $packages and import $ivy #3942

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 11, 2024

This helps make the IDE happy

Before:

Screenshot 2024-11-12 at 12 57 33 AM

After:

Screenshot 2024-11-12 at 1 23 51 AM

We can't do similar for import $file, because it conflicts with the => $file renaming import in the code generation. But hopefully that would be fixed later by #3894

@lihaoyi lihaoyi changed the title Add stubs for import $meta and import $packages Add stubs for import $meta and import $packages and import $ivy Nov 11, 2024
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea!

@lihaoyi lihaoyi marked this pull request as ready for review November 11, 2024 23:16
@lihaoyi lihaoyi merged commit 963ec6b into com-lihaoyi:main Nov 11, 2024
24 of 25 checks passed
@lefou lefou added this to the 0.12.3 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants