Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scala Native Example Code #3899

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix Scala Native Example Code #3899

merged 2 commits into from
Nov 4, 2024

Conversation

c0d33ngr
Copy link
Contributor

@c0d33ngr c0d33ngr commented Nov 3, 2024 •
edited by lefou
Loading

Follw up for #3647

@c0d33ngr c0d33ngr marked this pull request as ready for review November 3, 2024 19:46
@lihaoyi
Copy link
Member

lihaoyi commented Nov 3, 2024

CC @sideeffffect @lolgab as folks who know scala-native and gave feedback on the original PR

sideeffffect
sideeffffect reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scala Native now look fine to me. But unfortunately I don't know now why it fails the CI. Perhaps that's because I'm not familiar with Mill (and Mill's CI).

@c0d33ngr
Copy link
Contributor Author

c0d33ngr commented Nov 4, 2024 •
edited
Loading

The Scala Native now look fine to me. But unfortunately I don't know now why it fails the CI. Perhaps that's because I'm not familiar with Mill (and Mill's CI).

Alright... Thank you
It's on me about the CI test failing, I didn't update the test. I was waiting for review before I update it as I found out about it yesterday

sideeffffect
sideeffffect approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

lefou
lefou approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@lefou lefou changed the title Follow Up PR for Scala Native Example Code Fix Scala Native Example Code Nov 4, 2024
@lefou lefou merged commit 96c4057 into com-lihaoyi:main Nov 4, 2024
24 checks passed
@lefou lefou added this to the 0.12.2 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect approved these changes

@lolgab lolgab lolgab approved these changes

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.2
Development

Successfully merging this pull request may close these issues.
5 participants
@c0d33ngr @lihaoyi @lefou @lolgab @sideeffffect