Drop incremental compilation state for Mill modules when version changes #3884
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mill used various tricks to map build scripts written by users to generated enhanced versions, including package objects and other stuff. Since some of these techniques may result in Zinc undercompilation, we want avoid downstream issues, especally in the `methodCodeHashSignatures` task, which is sensitive to inconsistent bytecode. We trait potentially longer compilation against incorrect or too coarse code change detection, which may invalidate a lot more downstream tasks than needed due to invalid data. Fix com-lihaoyi#3874
|
Since we don't have a reproducer, this PR comes without a new test. |
This was referenced Nov 1, 2024
lihaoyi
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mill used various tricks to map build scripts written by users to generated enhanced versions, including package objects and other stuff.
Since some of these techniques may result in Zinc undercompilation, we want avoid downstream issues,
especally in the
methodCodeHashSignaturestask, which is sensitive to inconsistent bytecode.We trait potentially longer compilation against incorrect or too coarse code change detection, which may invalidate a lot more downstream tasks than needed due to invalid data.
Fix #3874