Add stub mill.define.Ctx to trick IntelliJ into not erroring
#3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Oct 28, 2024
| assert(e.msg.contains( | ||
| "Modules and Tasks can only be defined within a mill Module" | ||
| "Task{} members must be defs defined in a Cacher class/trait/object body" |
There was a problem hiding this comment.
Since Cacher never surfaces in our docs (and API), we probably should list the most likely candidate Module.
There was a problem hiding this comment.
Suggested change
| "Task{} members must be defs defined in a Cacher class/trait/object body" | |
| "Task{} members must be defs defined in a Cacher class/trait/object body like Module" |
There was a problem hiding this comment.
This actually comes from the mill-moduledefs repo, so we'll need to fix it upstream there https://github.com/com-lihaoyi/mill-moduledefs/blob/33a27d470a8f27a1cb2ad9e71d8c25b24294eee8/moduledefs/src-2/Cacher.scala#L29
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3558, but for
mill.define.Ctxrather thanmill.main.RootModule.Info. Because it's provided by the enclosing code-generation, we need to trick IntelliJ into thinking there is something it can use, and so I define a low priority implicit to fall back upon if the maindef makedoesn't work (but@compileTimeOnlyto show an error message if it ends up being needed)I moved the bulk of the cacher logic from
mill-moduledefstomill.define. We just need a marker trait inmill-moduledefs, and having the rest of the logic in Mill itself simplifies maintenance and evolution of the codeBefore
After
