Add a default config for logback #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we bundle the logback dependency, it runs with a built-in default config printing all messages with at least DEBUG level on the console. This can be very verbose. This change includes a default config creating a log file `out/mill.log` in the current workind directory. Since Mill server now always runs in a sandbox dir, this should not polute the users working directory. If a user is want to change the log configuration, she ca simple provide an alternatve config with `-Dlogback.configurationFile=/path/to/config.xml`
lihaoyi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we bundle the logback dependency, it runs with a built-in default config printing all messages with at least DEBUG level on the console. This can be very verbose.
This change includes a default config creating a log file
out/mill.login the current workind directory. Since Mill now always runs in a sandbox dir, this should not pollute the users working directory.If a user wants to change the log configuration, she can provide an alternative config with
-Dlogback.configurationFile=/path/to/config.xmlWe add the config file
logback.xmlto the runtime resources of thedistmodule, so it is only on the classpath of the Mill assembly. Since this assembly isn't expected on the classpath of other tools or libraries, we should avoid accidental downstream logging configurations.Fix #3671