-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestNg test runner #3813
Fix TestNg test runner #3813
Conversation
…k with TestNG
CC @lefou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Tested with a reasonable large TestNG test suite spawning 98 test processes.
Doesn't work properly without testForkGrouping now
@lihaoyi Looks like without custom |
Ah, we must have been running a single task because that task runs all tests within it for some reason |
@lefou I pushed an update with a fix and a test case, can try it out if you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Local tests seem to work for various fork groups. Thank you for this quick fix!
There is now no longer a single test summary at the end but one for each test class, which is a bit less convenient. Maybe Mill should print a summary, which would look more uniform over the various test frameworks anyways.
Fixes #3798, supersedes #3799
Not sure how this ever worked, but it seems like it works now
Converted the example test in #3799 to a unit test.