Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for prompt logger #3753

Merged
merged 21 commits into from
Oct 17, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 16, 2024

  1. Make EvaluatorCore waits for all non-exclusive tasks to finish before beginning to run exclusive tasks to prevent overlap
  2. Re-organize promptLineState/streamManager/runningState to ensure each piece of mutable state is only read by one of them
  3. Tweak PromptLoggerUtil.clearScreenToEndBytes to prevent the clearScreen from mucking up tab-stops in iTerm2
  4. Overhaul PromptLogger's synchronization strategy: we now no longer synchronize on child loggers writing to PromptLogger's streams, and only synchronize on PromptLogger writing to the parent systemStreams0 (including the writes coming from ProxyStream.Pumper) along with the operations mutating state within PromptLogger
  5. Ensure we only print the prompt in preRead if the previous character was a \n, to ensure that when log lines are broken over multiple read/writes we do not allow a prompt to be written in between the two parts of the line

(3) seems to fix #3752

@lihaoyi lihaoyi merged commit cca1e93 into com-lihaoyi:main Oct 17, 2024
24 checks passed
@lefou lefou added this to the 0.12.0 milestone Oct 17, 2024
lihaoyi added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabs interact badly with PromptLogger
2 participants