Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanups for PromptLogger #3712

Merged
merged 4 commits into from
Oct 10, 2024
Merged

More cleanups for PromptLogger #3712

merged 4 commits into from
Oct 10, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 10, 2024 •
edited
Loading

  • Move more pure logic into PromptLoggerUtil static methods
  • Make prompt line replacement logic more aggressive, such that even after dead lines finish transitioning they can be replaced, fixing an issue where the prompt height sometimes grew unnecessarily due to blank lines

@lihaoyi lihaoyi marked this pull request as ready for review October 10, 2024 13:19
@lihaoyi lihaoyi merged commit 01ab379 into com-lihaoyi:main Oct 10, 2024
24 checks passed
@lefou lefou added this to the 0.12.0 milestone Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou