Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala Native Examples #3657
Add Scala Native Examples #3657
Changes from 50 commits
3346097
52a38c4
367bcb0
a48faac
7df4367
cee766e
ef802d3
11a6e75
2783005
24b9543
b1015e7
8740b01
19ed282
2c9d4ec
61f53b7
9dc9053
4f3a61b
dfb0e5e
bd1f756
e41d609
69ffd7d
7cada73
bf2edb2
8dc0853
a367ead
55c143f
c37e9a0
24729ea
f047193
3919933
950440a
dda37bf
ca18f5f
7cbf92e
82ed7c0
ba260e5
aed36a5
d98e8c2
45fb020
1c5e946
8659821
6b5b1bf
956f223
f2c0e9e
5768cbd
7e312b2
8d3e300
495c44f
4501c2e
9242768
76bb361
a599da6
9ac2cc1
084dfb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
cResult
escape here theZone
where it was allocated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright... Noted
I'm into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-simple/src/Foo.scala
3-multi-module/foo/src/Foo.scala
3-multi-module/bar/src/Bar.scala
4-common-config/src/Foo.scala
Hello @sideeffffect Here's is the updated code. Are they good to go?
Also please do a review on the scala-native codes I wrote just in case there are some changes needed to be made. It came to my notice that doc should be as good it can be cause future readers would depend on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0d33ngr please open a new PR with these changes, it's easier to discuss individual code changes on the PR, and when we're done we can just click the merge button :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright..