Add Ktfmt support #3620
Merged
Add Ktfmt support #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @0xnm ! I'll transfer you the bounty using your earlier details |
lefou
reviewed
Sep 28, 2024
| * Ktfmt version. | ||
| */ | ||
| def ktfmtVersion: T[String] = T { | ||
| "0.52" |
There was a problem hiding this comment.
If we want to provide a default at all, we should at least source it from a BuildInfo generated at build/release time. That way, we can automate bumping this dependency as part of Mill's version management.
|
|
||
| object KtfmtModule extends ExternalModule with KtfmtBaseModule with TaskModule { | ||
|
|
||
| def kotlinVersion = "1.9.24" |
There was a problem hiding this comment.
I don't like this hardcoded version here. We should source it from some generated BuildInfo.
| ): Seq[os.Path] = { | ||
|
|
||
| object module extends TestBaseModule with KotlinModule with KtfmtModule { | ||
| override def kotlinVersion: T[String] = "1.9.24" |
There was a problem hiding this comment.
The version used here should be defined at the top of the test file. Same, for the other occurences.
lihaoyi
pushed a commit
that referenced
this pull request
Oct 1, 2024
Some minor cleanup for the previous work on the Kotlin-related modules: * Read tooling versions from build info (#3620 (comment) and #3620 (comment)) * Declare versions only once in the unit tests * Change parent module to `JavaModule` for Ktfmt support, because we don't need the code to be compiled in this module, so declaring Kotlin version there was looking a bit strange. In fact only `sources()` method is needed, which is available in the `JavaModule`. In the future `KotlinModule` may be split into different traits: the one which collects Kotlin+Java files, but doesn't do any compilation (so Kotlin version is not needed) and the one which actually does compilation. --------- Co-authored-by: 0xnm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3612.
This PR is based on the logic done in #3531, so it looks quite similar.