-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugins to run Checkstyle and generate reports #3516
Conversation
Pending
I suspect this is an environment issue. Will investigate further. |
@lihaoyi Please review. |
* }}} | ||
*/ | ||
def checkstyleXsltReports: T[Set[CheckstyleXsltReport]] = T { | ||
val dir = millSourcePath / "checkstyle-xslt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved into a T.source
task to ensure changes to that upstream folder properly invalidate this downstream target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove CheckstyleXsltReport
and replace checkstyleXsltReports
with
def checkstyleXslt: T[Seq[PathRef]] = T.sources { ??? }
def checkstyleXsltOutput: T[Seq[PathRef]] = T { ??? }
I can submit a PR. Let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, I already opened on #3522
I think this looks good, if you're happy with it I'll merge it. Another CheckStyle PR has been submitted that has also been of great help understanding the solution space (#3472), so I'll pay out 70% of the bounty for this one and 30% of the bounty for the other. @ajaychandran email me your bank transfer details and I'll wire it over |
@lihaoyi Thank you for the guidance. |
Added plugins
CheckstyleModule
, fully compliant with Checkstyle CLICheckstyleXsltModule
, generates reports by applying XSL Transformations on a Checkstyle output reportResolves #3332.