Properly close Scala compiler classloaders in server and unit tests #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
force-pushed
the
unit-tester-scoped
branch
from
aaaf2f8 to
ab38feb
Compare
lefou
reviewed
Sep 6, 2024
|
|
||
| // Make sure we at least pick up all the URLClassLoaders, since we know those are | ||
| // AutoCloseable, although there may be other AutoCloseable classloaders as well | ||
| assert(urlClassLoaders.toSet[AutoCloseable].subsetOf(closeableClassloaders.toSet)) |
There was a problem hiding this comment.
This assert could fail at runtime, potentially breaking a workflow that was working before. Since we're just detecting after the fact, a log/error message without a hard failure would be more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were just leaking the
URLClassLoaders, which would giveCodeHeap 'non-profiled nmethods' is full. Compiler has been disabled.inscalajslib.testand sometimes in actual usage for a long lived server. This PR ensures weZincWorkerImpl.closeactually callsURLClassLoader.close, and also replacedval eval = UnitTesterin our test suite withUnitTester.scoped{ eval =>so we can ensure closing of theUnitTesterandURLClassLoaderafter each test completesWith this change,
scalajslib.testno longer prints the above error. Hopefully it makes it stop happening in production as well.scalajslib.testalso drops from 7.5min to 6.5min (and drops further to 5min when I removed Scala.js 1.3.1 from the test matrix)