Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since os-lib propagates the system environment by default when it runs subprocesses, setting
forkEnv
to the system environment, is redundant, but also confusing, since removing a key from the Map doesn't stop mill to pass the environment variable to the run program. This sets a new default, which is a semantic breaking change, so it should go in Mill 0.12.0, which is a binary compatible but behavior incompatible release.Pull Request: #3442