Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenIdea: unroll module dependencies #3355

Merged
merged 4 commits into from
Aug 9, 2024
Merged

GenIdea: unroll module dependencies #3355

merged 4 commits into from
Aug 9, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Aug 8, 2024

Since IDEA 2024.2, module dependencies in the .iml files are no longer interpreted transitively.
Therefore, we need to unroll all transitive module dependencies when generating the project files.

Fix #3354

lefou added 2 commits August 9, 2024 07:46
Since IDEA 2024.2, module dependencies in the `.iml` files are no longer interpreted transitively.
Therefore, we need to unroll all transitive module dependencies when generating the project files.

Fix #3354
@lefou lefou force-pushed the idea-module-deps branch from 6498c56 to ed681b3 Compare August 9, 2024 05:46
@lefou lefou merged commit 6cf6ce1 into main Aug 9, 2024
31 checks passed
@lefou lefou deleted the idea-module-deps branch August 9, 2024 07:01
@lefou lefou added this to the 0.12.0 milestone Aug 9, 2024
lefou added a commit that referenced this pull request Aug 9, 2024
Since IDEA 2024.2, module dependencies in the `.iml` files are no longer
interpreted transitively.
Therefore, we need to unroll all transitive module dependencies when
generating the project files.

Fix #3354

Original Pull request: #3355
lefou added a commit that referenced this pull request Aug 9, 2024
Since IDEA 2024.2, module dependencies in the `.iml` files are no longer
interpreted transitively.
Therefore, we need to unroll all transitive module dependencies when
generating the project files.

Fix #3354

Original Pull request: #3355

Pull request: #3358
@lefou
Copy link
Member Author

lefou commented Aug 15, 2024

Although we fixed this issue as it was a confirmed change in IDEA (via Discord, can't link), it seems it was an unplanned regression.

See issue https://youtrack.jetbrains.com/issue/SCL-22935

It should be fixed in IDEA 2024.2.567 (Nightly), so we need to check later, whether we want/need to revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDEA 2024.2 changed to non-transitive module dependencies
1 participant