Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cobertura XML report task to help integration #3093

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

romain-gilles-ultra
Copy link
Contributor

@romain-gilles-ultra romain-gilles-ultra commented Mar 19, 2024

To help the integration of Mill based projects in some CI/CD platforms like GitLab you have to support Cobertura XML-based coverage report.
This PR adds a new ReportType and its corresponding action to produce Cobertura XML-based coverage report.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've one comment below and the format check failed. Please reformat the changed files or run

> mill mill.scalalib.scalafmt.ScalafmtModule/reformatAll __.sources

contrib/scoverage/readme.adoc Outdated Show resolved Hide resolved
@romain-gilles-ultra
Copy link
Contributor Author

Looks good to me. I've one comment below and the format check failed. Please reformat the changed files or run

> mill mill.scalalib.scalafmt.ScalafmtModule/reformatAll __.sources

Done reformat the code 👍

Co-authored-by: Tobias Roeser <[email protected]>
contrib/scoverage/readme.adoc Outdated Show resolved Hide resolved
@lefou lefou merged commit 75a73ff into com-lihaoyi:main Mar 19, 2024
36 checks passed
@lefou lefou added this to the 0.11.8 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants