Prepare the Scala.js integration for SIP-51. #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Scala.js 1.15.0+ together with Scala 2, we now add an explicit dependency to the `scalajs-scalalib` artifact. That artifact comes with Scala.js 1.15.0+, and is double-versioned with the Scala version and the Scala.js version. As SIP-51 gets implemented and future versions of the Scala library may break forward binary compatibility, the new `scalajs-scalalib` will be able to bring in new APIs back to existing Scala.js versions. This commit mimics the changes done to sbt-scalajs in https://github.com/scala-js/scala-js/pull/4913/files#diff-adc7ad642b8f89aab3d2a81ac25b23e345bbea758b1c8bbea46cc9d1f351834c
sjrd
force-pushed
the
prepare-scalajs-sip-51
branch
from
50d9d41 to
baebdd4
Compare
|
Thank you for opening this pull request, @sjrd . It looks reasonable. What's the next step? Should we merge it right away or wait for some state change / announcement of SIP-51? |
|
It can be merged right away. sbt-scalajs 1.15.0 already behaves this way. It is already beneficial irrespective of SIP-51 (though with much smaller consequences): if there is a bugfix in a newer version of the standard library, users of the new Scala version will get the bug fix, instead of having to wait for a newer version of Scala.js that has itself upgraded to the newer Scala. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Scala.js 1.15.0+ together with Scala 2, we now add an explicit dependency to the
scalajs-scalalibartifact. That artifact comes with Scala.js 1.15.0+, and is double-versioned with the Scala version and the Scala.js version.As SIP-51 gets implemented and future versions of the Scala library may break forward binary compatibility, the new
scalajs-scalalibwill be able to bring in new APIs back to existing Scala.js versions.This commit mimics the changes done to sbt-scalajs in https://github.com/scala-js/scala-js/pull/4913/files#diff-adc7ad642b8f89aab3d2a81ac25b23e345bbea758b1c8bbea46cc9d1f351834c