Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support release-size releaseMode in Scala Native #2754

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Support release-size releaseMode in Scala Native #2754

merged 4 commits into from
Sep 18, 2023

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Sep 18, 2023

No description provided.

lefou
lefou reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I took the opportunity to add some scaladoc.

scalanativelib/src/mill/scalanativelib/api/ScalaNativeApi.scala Show resolved Hide resolved
@lolgab lolgab marked this pull request as ready for review September 18, 2023 17:10
@lefou lefou merged commit 55d04b4 into com-lihaoyi:main Sep 18, 2023
35 checks passed
@lefou lefou added this to the 0.11.4 milestone Sep 18, 2023
@lolgab lolgab deleted the release-size-scalanative branch September 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @lefou