Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contrib.buildinfo use compileModuleDeps rather than moduleDeps #2568

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jun 4, 2023

Follow up from #2562, to avoid potentially having duplicate Mill classfiles on the classpath

@lihaoyi lihaoyi marked this pull request as ready for review June 4, 2023 22:38
@lihaoyi lihaoyi merged commit 1535a7b into com-lihaoyi:main Jun 5, 2023
@lefou lefou added this to the 0.11.0-M11 milestone Jun 5, 2023
@lolgab
Copy link
Member

lolgab commented Jun 5, 2023

If we want to avoid the dependency to scalajslib and scalanativelib we can maybe use reflection or structural types to check if the module is a ScalaJSModule, for example by checking if the module has scalaJSVersion: Target[String] available or scalaNativeVersion: Target[String].

PR implementing the approach here: #2569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants