Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up mill.eval even more #2542

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented May 24, 2023

  1. Terminal goes in its own file
  2. Split out EvaluatorCore (which contains only evaluation-related stuff) from EvaluatorImpl (which contains some user-facing helpers)
  3. Split out GroupEvaluator from EvaluatorCore
  4. Split out Plan, ThreadNumberer, JsonArrayLogger
  5. Unify implementation of mill-profile.json and mill-par-profile.json (renamed mill-chrome-profile.json), so they both perform streaming as-evaluation-progresses logging in a thread-safe manner (should fix Randomly ConcurrentModificationException #2540)
  6. Add dependencies to mill-profile.json, making it more useful since you can now trace up and down the build graph without having to run mill inspect (which would wipe out the mill-profile.json you were just looking at!)

@lihaoyi lihaoyi changed the title Break up EvaluatorImpl even more Clean up EvaluatorImpl even more May 24, 2023
@lihaoyi lihaoyi changed the title Clean up EvaluatorImpl even more Clean up mill.eval even more May 24, 2023
@lihaoyi lihaoyi marked this pull request as ready for review May 24, 2023 03:50
@lihaoyi lihaoyi merged commit e153520 into com-lihaoyi:main May 24, 2023
@lefou lefou added this to the 0.11.0-M10 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomly ConcurrentModificationException
2 participants