Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclusions and custom configuration to dependencies #254

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

shengc
Copy link
Contributor

@shengc shengc commented Mar 21, 2018

partly borrow the idea from #214, but also reflect the exclusions in ivy and pom generation.

@lihaoyi
Copy link
Member

lihaoyi commented Mar 22, 2018

@shengc can we have a unit test for this?

@shengc
Copy link
Contributor Author

shengc commented Mar 22, 2018

@lihaoyi sure, I have to do this after hours. Is the unit test supposed to be under integration/test, or somewhere else ?

@lihaoyi
Copy link
Member

lihaoyi commented Mar 22, 2018

@shengc probably one unit test in https://github.com/lihaoyi/mill/tree/master/scalalib/test/src/mill/scalalib to test that resolving does the right thing and the classpath is properly missing the jar that got excluded

@shengc
Copy link
Contributor Author

shengc commented Mar 24, 2018

@lihaoyi tests are in.

@lihaoyi
Copy link
Member

lihaoyi commented Mar 27, 2018

Looks good to me, thanks!

@lihaoyi lihaoyi merged commit a4713c3 into com-lihaoyi:master Mar 27, 2018
lihaoyi added a commit that referenced this pull request Apr 2, 2018
shengc pushed a commit to shengc/mill that referenced this pull request Apr 2, 2018
shengc pushed a commit to shengc/mill that referenced this pull request Apr 2, 2018
shengc pushed a commit to shengc/mill that referenced this pull request Apr 2, 2018
rockjam pushed a commit that referenced this pull request Apr 2, 2018
lihaoyi added a commit that referenced this pull request Apr 6, 2018
robby-phd added a commit that referenced this pull request Apr 7, 2018
* fix build

* Detect sh/batch launcher, dev.assembly, and release filename.

* Updated appveyor cache.

* Added some entries for master in readme.md changelog.

* Updated readme.md changelog.

* fixes #173; use default(compile) configuration for deps as default (#270)

* revert #254 to fix bootstrapping #268

* Updated ci tests.

* Reverted Ammonite caching workaround (a796f0a) now that it's fixed

* Changed ci/test-mill-0.sh to use interactive mode due to intermittent client failures to connect to server in travis

* Added ci/test-mill-bootstrap.sh (ci/test-mill-0.sh with bootstrapping) and use it on oraclejdk9 instead of ci/test-mill-0.sh

* Upgraded mill used for ci to 0.1.7-29-f5097f

* revive #254 and fix #268 (#274)

* Test mill batch (.bat) in AppVeyor

* fix minor typos in docs

* Sync Ammonite in ScalaModule (with build.sc).
@lefou lefou added this to the 0.2.0 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants