Remove the ability for T.inputs and T.sources to take input tasks #2488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T.sources
orT.input
taking task inputs used to be necessary to allow them to be overriden and extended, e.g.However that workflow is no longer necessary since #2402 landed, since now you can do:
Which is generally more correct, since the current task is no longer a "source" input to the Mill build graph, but rather an intermediate target like any other.
The fact that
T.input
s andT.source
s can themselves take input tasks isn't very intuitive, since most people do not imagine that build graph tasks can both be inputs as intermediate targets at the same time. Since it is now no longer necessary, better to prohibit it unless there's a strong reason not to, to simplify the data/execution model and reduce the unnecessarily different ways of implementing the same buildTested via
compileError
assertions inMacroErrorTests.scala