Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upickle to 2.0.0 #1854

Merged
merged 7 commits into from
May 2, 2022
Merged

Conversation

scala-steward
Copy link
Contributor

Updates com.lihaoyi:upickle from 1.6.0 to 2.0.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.6.0).
You might want to review and update them manually.

readme.adoc
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "upickle" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "com.lihaoyi", artifactId = "upickle" }
}]

labels: library-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

@lefou
Copy link
Member

lefou commented May 2, 2022

@lihaoyi Is it safe to bump this? Meaning, can a project switch from Mill 0.10.0 to main (0.10.x) and back without build issues caused by upickle format changes?

@lihaoyi
Copy link
Member

lihaoyi commented May 2, 2022

@lefou my understanding is we invalidate all caches aggressively on any classpath change, so this should be safe. Caches will be busted, but no different from any other Mill code change

@lefou
Copy link
Member

lefou commented May 2, 2022

@lihaoyi Thanks. Looks like it's safe enough, then.

@lefou lefou merged commit 2cae729 into com-lihaoyi:main May 2, 2022
@lefou lefou added this to the after 0.10.3 milestone May 2, 2022
lolgab added a commit that referenced this pull request May 5, 2022
lefou added a commit to lefou/mill that referenced this pull request May 5, 2022
Turns out, it causes instable caches when switching mill server mode, which results in perceived full cache invalidations.

This reverts pull request: com-lihaoyi#1854
@lefou lefou mentioned this pull request May 5, 2022
@lolgab
Copy link
Member

lolgab commented May 5, 2022

I'm observing a regression after this update.
Everytime I restart the server all the build files get recompiled from scratch even if they were not touched at all.
Can it be because Ammonite depends on upickle 1.6.0 while Mill uses 2.0.0 ?

lefou added a commit that referenced this pull request May 5, 2022
Turns out, it causes instable caches when switching mill server mode, which results in perceived full cache invalidations.

This reverts pull request: #1854

Pull request: #1865
@scala-steward scala-steward deleted the update/upickle-2.0.0 branch May 5, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants