Prevent compilation during bloop config generation #1352
Conversation
| @@ -195,81 +195,6 @@ class BloopImpl(ev: () => Evaluator, wd: Path) extends ExternalModule { outer => | |||
| case _ => T.task(None) | |||
| } | |||
|
|
|||
| //////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
moved below to prevent a forward-reference.
| ), | ||
| mainClass = module.mainClass(), | ||
| runtimeConfig = None, | ||
| classpath = Some(classpath().map(_.toNIO).toList), |
There was a problem hiding this comment.
This is the only line that changed.
It would be good to understand what bloop uses this for
There was a problem hiding this comment.
Isn't that just classpath for compilation?
There was a problem hiding this comment.
Nope, the classpath for compilation is there
There was a problem hiding this comment.
I mean, yeah, the value that I'm assigning to the config (in this PR) is the the same as the one that's used for compilation, but here I'm asking about the meaning of that particular configuration element.
There was a problem hiding this comment.
Wait, that is in platform, let me check it.
There was a problem hiding this comment.
So this was added as a separate configuration for running on JVM. More info in the commit scalacenter/bloop@8898a93
There was a problem hiding this comment.
Right so according to the comment it could be left empty. Right ?
There was a problem hiding this comment.
It will use the main classpath if it's missing. Looks like it.
Bloop will fallback to the value present in the Project object.
Compilation of a module and its upstreams should be avoided at all cost when generating bloop configuration.
#1086 adds a reference to a task that depends on
compile. This PR prevents that from happening, and adds a test to ensure that compilation isn't triggered byBloop/install@tgodzik
@lolgab