Read default Scala Native env variables #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase to latest master, which should produce cleaner CI results? |
- Make `nativeOptimize` configurable - Env variables are proper `T.input`s and are evaluated every time
lolgab
force-pushed
the
scala-native-env-variables
branch
from
39b282b to
aa2f3dc
Compare
|
@lefou Can this be merged? The CI steps that are failing are failing in master too. |
|
Sure. Thank you! |
lolgab
added a commit
to lolgab/mill
that referenced
this pull request
Apr 7, 2021
- com-lihaoyi#1253 used `valueOf` which given a Java `enum` it matches the name of the classes and not the string values that match the official Scala Native env variables values. This PR uses instead `.values` which returns all the values then matches based on the `String value` the enums define.
lefou
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Fix Scala Native env variables values to match sbt - #1253 used `valueOf` which given a Java `enum` it matches the name of the classes and not the string values that match the official Scala Native env variables values. This PR uses instead `.values` which returns all the values then matches based on the `String value` the enums define. * Make tasks inputs protected in ScalaNativeModule Pull request: #1258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeOptimizeconfigurableT.inputs and are evaluated every time