Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump scala version: 2.13.3 -> 2.13.4 and 2.12.10 -> 2.12.13 #1197

Merged
merged 3 commits into from
May 25, 2021
Merged

Bump scala version: 2.13.3 -> 2.13.4 and 2.12.10 -> 2.12.13 #1197

merged 3 commits into from
May 25, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 6, 2021

No description provided.

@lefou
Copy link
Member Author

lefou commented Mar 7, 2021 •
edited
Loading

Build error related: #1116 (comment)

[346/569] main.client.compile 
[info] compiling 9 Java sources to /home/runner/work/mill/mill/out/main/client/compile/dest/classes ...
Error:  ## Exception when compiling 9 sources to /home/runner/work/mill/mill/out/main/client/compile/dest/classes
Error:  java.util.ConcurrentModificationException: mutation occurred during iteration
Error:  scala.collection.mutable.MutationTracker$.checkMutations(MutationTracker.scala:43)
Error:  scala.collection.mutable.MutationTracker$CheckedIterator.hasNext(MutationTracker.scala:59)
Error:  scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
Error:  scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
Error:  scala.collection.AbstractIterable.foreach(Iterable.scala:919)
Error:  sbt.internal.inc.ClassToAPI$.process(ClassToAPI.scala:34)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.readAPI$1(AnalyzingJavaCompiler.scala:180)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$23(AnalyzingJavaCompiler.scala:205)
Error:  sbt.internal.inc.classfile.JavaAnalyze$.readInheritanceDependencies$1(JavaAnalyze.scala:194)
Error:  sbt.internal.inc.classfile.JavaAnalyze$.$anonfun$apply$15(JavaAnalyze.scala:201)
Error:  sbt.internal.inc.classfile.JavaAnalyze$.$anonfun$apply$15$adapted(JavaAnalyze.scala:110)
Error:  scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
Error:  scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
Error:  scala.collection.AbstractIterable.foreach(Iterable.scala:919)
Error:  scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:889)
Error:  sbt.internal.inc.classfile.JavaAnalyze$.apply(JavaAnalyze.scala:110)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$21(AnalyzingJavaCompiler.scala:205)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$21$adapted(AnalyzingJavaCompiler.scala:199)
Error:  scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
Error:  scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
Error:  scala.collection.AbstractIterable.foreach(Iterable.scala:919)
Error:  scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:889)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$19(AnalyzingJavaCompiler.scala:199)
Error:  scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.timed(AnalyzingJavaCompiler.scala:251)
Error:  sbt.internal.inc.javac.AnalyzingJavaCompiler.compile(AnalyzingJavaCompiler.scala:199)
Error:  sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compileJava$1(MixedAnalyzingCompiler.scala:98)
Error:  scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
Error:  sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:241)
Error:  sbt.internal.inc.MixedAnalyzingCompiler.compileJava(MixedAnalyzingCompiler.scala:61)
Error:  sbt.internal.inc.MixedAnalyzingCompiler.compileJava0$1(MixedAnalyzingCompiler.scala:191)
Error:  sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:204)
Error:  sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:573)
Error:  sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:573)
Error:  sbt.internal.inc.Incremental$.$anonfun$apply$5(Incremental.scala:174)
Error:  sbt.internal.inc.Incremental$.$anonfun$apply$5$adapted(Incremental.scala:172)
Error:  sbt.internal.inc.Incremental$$anon$2.run(Incremental.scala:459)
Error:  sbt.internal.inc.IncrementalCommon$CycleState.next(IncrementalCommon.scala:116)
Error:  sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:56)
Error:  sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:52)
Error:  sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:261)
Error:  sbt.internal.inc.Incremental$.$anonfun$incrementalCompile$8(Incremental.scala:414)
Error:  sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:499)
Error:  sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:401)
Error:  sbt.internal.inc.Incremental$.apply(Incremental.scala:166)
Error:  sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:573)
Error:  sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:491)
Error:  sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332)
Error:  sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:420)
Error:  sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137)
Error:  mill.scalalib.worker.ZincWorkerImpl.compileInternal(ZincWorkerImpl.scala:512)
Error:  mill.scalalib.worker.ZincWorkerImpl.compileJava0(ZincWorkerImpl.scala:257)
Error:  mill.scalalib.worker.ZincWorkerImpl.compileJava(ZincWorkerImpl.scala:243)
Error:  mill.scalalib.JavaModule.$anonfun$compile$2(JavaModule.scala:231)
Error:  mill.define.ApplyerGenerated.$anonfun$zipMap$4(ApplicativeGenerated.scala:11)
Error:  mill.define.Task$MappedDest.evaluate(Task.scala:391)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroup$13(Evaluator.scala:491)
Error:  scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
Error:  scala.Console$.withErr(Console.scala:193)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroup$12(Evaluator.scala:491)
Error:  scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
Error:  scala.Console$.withOut(Console.scala:164)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroup$11(Evaluator.scala:490)
Error:  scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
Error:  scala.Console$.withIn(Console.scala:227)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroup$8(Evaluator.scala:489)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroup$8$adapted(Evaluator.scala:441)
Error:  scala.collection.immutable.Vector.foreach(Vector.scala:1856)
Error:  mill.eval.Evaluator.evaluateGroup(Evaluator.scala:441)
Error:  mill.eval.Evaluator.$anonfun$evaluateGroupCached$13(Evaluator.scala:343)
Error:  scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
Error:  mill.eval.Evaluator.evaluateGroupCached(Evaluator.scala:334)
Error:  mill.eval.Evaluator.$anonfun$sequentialEvaluate$2(Evaluator.scala:117)
Error:  scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
Error:  scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
Error:  scala.collection.AbstractIterator.foreach(Iterator.scala:1279)
Error:  mill.eval.Evaluator.sequentialEvaluate(Evaluator.scala:94)
Error:  mill.eval.Evaluator.evaluate(Evaluator.scala:80)
Error:  mill.main.RunScript$.evaluate(RunScript.scala:202)
Error:  mill.main.RunScript$.$anonfun$evaluateTasks$1(RunScript.scala:188)
Error:  scala.util.Either.map(Either.scala:382)
Error:  mill.main.RunScript$.evaluateTasks(RunScript.scala:187)
Error:  mill.main.RunScript$.$anonfun$runScript$4(RunScript.scala:66)
Error:  ammonite.util.Res$Success.flatMap(Res.scala:62)
Error:  mill.main.RunScript$.runScript(RunScript.scala:65)
Error:  mill.main.MainRunner.$anonfun$runScript$1(MainRunner.scala:118)
Error:  mill.main.MainRunner.watchLoop2(MainRunner.scala:67)
Error:  mill.main.MainRunner.runScript(MainRunner.scala:93)
Error:  mill.MillMain$.main0(MillMain.scala:215)
Error:  mill.MillMain$.main(MillMain.scala:83)
Error:  mill.MillMain.main(MillMain.scala)
Error:             
1 targets failed
main.client.compile java.util.ConcurrentModificationException: mutation occurred during iteration
    scala.collection.mutable.MutationTracker$.checkMutations(MutationTracker.scala:43)
    scala.collection.mutable.MutationTracker$CheckedIterator.hasNext(MutationTracker.scala:59)
    scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
    scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
    scala.collection.AbstractIterable.foreach(Iterable.scala:919)
    sbt.internal.inc.ClassToAPI$.process(ClassToAPI.scala:34)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.readAPI$1(AnalyzingJavaCompiler.scala:180)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$23(AnalyzingJavaCompiler.scala:205)
    sbt.internal.inc.classfile.JavaAnalyze$.readInheritanceDependencies$1(JavaAnalyze.scala:194)
    sbt.internal.inc.classfile.JavaAnalyze$.$anonfun$apply$15(JavaAnalyze.scala:201)
    sbt.internal.inc.classfile.JavaAnalyze$.$anonfun$apply$15$adapted(JavaAnalyze.scala:110)
    scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
    scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
    scala.collection.AbstractIterable.foreach(Iterable.scala:919)
    scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:889)
    sbt.internal.inc.classfile.JavaAnalyze$.apply(JavaAnalyze.scala:110)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$21(AnalyzingJavaCompiler.scala:205)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$21$adapted(AnalyzingJavaCompiler.scala:199)
    scala.collection.IterableOnceOps.foreach(IterableOnce.scala:563)
    scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:561)
    scala.collection.AbstractIterable.foreach(Iterable.scala:919)
    scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:889)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.$anonfun$compile$19(AnalyzingJavaCompiler.scala:199)
    scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.timed(AnalyzingJavaCompiler.scala:251)
    sbt.internal.inc.javac.AnalyzingJavaCompiler.compile(AnalyzingJavaCompiler.scala:199)
    sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compileJava$1(MixedAnalyzingCompiler.scala:98)
    scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
    sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:241)
    sbt.internal.inc.MixedAnalyzingCompiler.compileJava(MixedAnalyzingCompiler.scala:61)
    sbt.internal.inc.MixedAnalyzingCompiler.compileJava0$1(MixedAnalyzingCompiler.scala:191)
    sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:204)
    sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:573)
    sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:573)
    sbt.internal.inc.Incremental$.$anonfun$apply$5(Incremental.scala:174)
    sbt.internal.inc.Incremental$.$anonfun$apply$5$adapted(Incremental.scala:172)
    sbt.internal.inc.Incremental$$anon$2.run(Incremental.scala:459)
    sbt.internal.inc.IncrementalCommon$CycleState.next(IncrementalCommon.scala:116)
    sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:56)
    sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:52)
    sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:261)
    sbt.internal.inc.Incremental$.$anonfun$incrementalCompile$8(Incremental.scala:414)
    sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:499)
    sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:401)
    sbt.internal.inc.Incremental$.apply(Incremental.scala:166)
    sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:573)
    sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:491)
    sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332)
    sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:420)
    sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137)
    mill.scalalib.worker.ZincWorkerImpl.compileInternal(ZincWorkerImpl.scala:512)
    mill.scalalib.worker.ZincWorkerImpl.compileJava0(ZincWorkerImpl.scala:257)
    mill.scalalib.worker.ZincWorkerImpl.compileJava(ZincWorkerImpl.scala:243)
    mill.scalalib.JavaModule.$anonfun$compile$2(JavaModule.scala:231)
    mill.define.ApplyerGenerated.$anonfun$zipMap$4(ApplicativeGenerated.scala:11)
    mill.define.Task$MappedDest.evaluate(Task.scala:391)
Error: Process completed with exit code 1.

@lefou
Copy link
Member Author

lefou commented Apr 15, 2021

Blocked by sbt/zinc#974

@lefou lefou marked this pull request as draft April 23, 2021 08:42
@lolgab
Copy link
Member

lolgab commented May 23, 2021

@lefou The blocker should be solved now. Mill is already on zinc 1.5.3 that has your fix.

@lefou
Copy link
Member Author

lefou commented May 24, 2021

@lefou The blocker should be solved now. Mill is already on zinc 1.5.3 that has your fix.

Yeah, I'm very aware of that. But unfortuntely just buming zinc wasn't enough to bring mill to newer scala versions. And I wasn't able to get to the root cause (or maybe I just don't remember right now). There is more work to do, before we can support newer scala versions.

@lefou
Copy link
Member Author

lefou commented May 24, 2021

I think I already sync'ed the branch #1185 and it still failed. It's probably related to support for older ScalaJS versions.

@lolgab
Copy link
Member

lolgab commented May 25, 2021 •
edited
Loading

I think I already sync'ed the branch #1185 and it still failed. It's probably related to support for older ScalaJS versions.

The Scala Steward PR is wrong because it is trying to update to Scala 2.13.5 in the tests too which doesn't work, since there is no Scala.js release for Scala 2.13.5 / Scala.js 1.4.0.
I tried to run the Scala.js tests locally from this branch (after a rebase) and I saw no problems.

@lefou
Copy link
Member Author

lefou commented May 25, 2021

@lolgab Thanks for reviewing and pointing that out. I guess I lost the overview with all these bumps ;-).

I synchronized this PR with latest main. 🤞

@lefou lefou mentioned this pull request May 25, 2021
Closed
@lefou lefou marked this pull request as ready for review May 25, 2021 12:48
@lefou lefou merged commit 213b607 into com-lihaoyi:main May 25, 2021
@lefou lefou deleted the scala-version-bump branch May 25, 2021 12:49
@lefou lefou added this to the after 0.9.7 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.8
Development

Successfully merging this pull request may close these issues.
2 participants
@lefou @lolgab