Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1142 by wrapping the JAVACMD variable in double quotes #1143

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

izeigerman
Copy link
Contributor

No description provided.

@izeigerman izeigerman changed the title Fix #1142 by wrapping the JAVACMD varabile in double quotes Fix #1142 by wrapping the JAVACMD variable in double quotes Feb 4, 2021
@izeigerman
Copy link
Contributor Author

Doesn't look like the test failure is related to my change

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the pull request!

@lefou lefou merged commit 1902838 into com-lihaoyi:master Feb 4, 2021
@lefou lefou added this to the after 0.9.5 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants