Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing trait in custom ZincWorkerModule example #1140

Conversation

alexarchambault
Copy link
Collaborator

@alexarchambault alexarchambault commented Feb 3, 2021

While following the instructions to use a custom ZincWorkerModule, things didn't compile until CoursierModule was added too. (It seems it's a self type of ZincWorkerModule now.) This PR updates the documentation accordingly.

@lefou
Copy link
Member

lefou commented Feb 3, 2021

You're right about the self type. Thank you!

@lefou lefou merged commit 8e56acb into com-lihaoyi:master Feb 3, 2021
@lefou lefou added this to the after 0.9.5 milestone Feb 3, 2021
@alexarchambault alexarchambault deleted the update-custom-zinc-worker-module-docs branch February 3, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants