Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bloop to 1.4.6-33-1c6f6712 #1133

Merged
merged 3 commits into from
Jan 31, 2021
Merged

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jan 29, 2021

  • Remove Scala Native deprecations

@lolgab lolgab marked this pull request as ready for review January 29, 2021 16:18
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Remove Scala Native deprecations
@lolgab
Copy link
Member Author

lolgab commented Jan 30, 2021

@lefou Rebased on top of current master.

@@ -25,7 +25,7 @@ object BloopTests extends TestSuite {

object scalaModule extends scalalib.ScalaModule with testBloop.Module {
def scalaVersion = "2.12.8"
val bloopVersion = "1.4.6"
val bloopVersion = "1.4.6-33-1c6f6712"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intention is, to use the same version for testing as for building, then we should probably think about generating some Versions file in build.sc and use it here, as we do in other modules.

Copy link
Member Author

@lolgab lolgab Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I'm fine to merge after CI succeedes. Your PRs are a pleasure.

@lefou lefou merged commit 8881566 into com-lihaoyi:master Jan 31, 2021
@lefou lefou added this to the after 0.9.5 milestone Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants