-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bloop to 1.4.6-33-1c6f6712 #1133
Conversation
lolgab
commented
Jan 29, 2021
- Remove Scala Native deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
- Remove Scala Native deprecations
@lefou Rebased on top of current master. |
@@ -25,7 +25,7 @@ object BloopTests extends TestSuite { | |||
|
|||
object scalaModule extends scalalib.ScalaModule with testBloop.Module { | |||
def scalaVersion = "2.12.8" | |||
val bloopVersion = "1.4.6" | |||
val bloopVersion = "1.4.6-33-1c6f6712" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention is, to use the same version for testing as for building, then we should probably think about generating some Versions
file in build.sc
and use it here, as we do in other modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I'm fine to merge after CI succeedes. Your PRs are a pleasure.