Support Scala Native 0.4.0 #1108
Conversation
- Drop support for Scala Native 0.3 - Remove `Release` ReleaseMode - Make `nativeTarget` `Option[String]` like upstream - Rewrote tests to JUnit. Since Scala Native ships with JUnit and Utest depends on Mill itself we can't use it to test Mill. JUnit is the official testing framework and stresses all the features that were tested with Utest and Scalatest - Testing Scala Native for Scala 2.11, 2.12 and 2.13 - Move worker again into the `0.4` folder. It was moved outside using `def millSourcePath = super.millSourcePath / os.up` to reuse the code between worker `0.3` and `0.4`. Since now we're dropping `0.3` it doesn't make sense anymore to do this, and we can be prepared for a future 0.5
| override def sources = T.sources{ millSourcePath / "src" / "no-tests" } | ||
| def testFrameworks = Seq("com.novocode.junit.JUnitFramework") | ||
| override def ivyDeps = Agg( | ||
| ivy"org.scala-native::junit-runtime::$sNativeVersion" | ||
| ) | ||
| override def compileIvyDeps = Agg( | ||
| ivy"org.scala-native:::junit-plugin:$sNativeVersion" | ||
| ) |
There was a problem hiding this comment.
This looks like a repetitiion of the JUnit-variant. Maybe, we can have it in a shared trait?
There was a problem hiding this comment.
Extracted on a separate trait ✅
| @@ -0,0 +1,14 @@ | |||
| package mill.scalanativelib.api; | |||
There was a problem hiding this comment.
This source files should be located in a directory structure reflecting the package name. The Java Standard isn't as flexible as the Scala one. Beside the fact that it just works with zinc, it won't for pure Java compiler.
Same, for all other Java files.
There was a problem hiding this comment.
@lefou You're right! Moved them ✅
- Move Java file to a directory structure based on package - Fix not compiling tests - Extract JUnit test setting in a trait in tests - Remove deprecated nativeLib config from worker It is still in ScalaNativeModule because bloop depends on it. I will remove it when Bloop will be updated to Scala Native 0.4.0 too
|
@lefou I tried in every way on earth to make the Scala Native JUnit framework to work on mill but I can't make it work. |
lolgab
changed the title
lolgab
force-pushed
the
update-scala-native-0.4.0
branch
from
36b33e4 to
36067fe
Compare
@lolgab Makes sense. But I have no idea how long until a newer utest is released. Did you requested your changes for merge? Let me restart Github tests first. If everything is green, we can merge to get a new snapshot release. |
|
Build is green 🎉 |
|
Thank you! |
ReleaseReleaseModenativeTargetOption[String]like upstreamdepends on Mill itself we can't use it to test Mill.
JUnit is the official testing framework and stresses all the features
that were tested with Utest and Scalatest
0.4folder. It was moved outside usingdef millSourcePath = super.millSourcePath / os.upto reuse the codebetween worker
0.3and0.4. Since now we're dropping0.3itdoesn't make sense anymore to do this, and we can be prepared for a
future 0.5