Fix InvalidPathException using BSP on Windows. #1092
Conversation
Upgrade bsp4j and implement buildTarget/javacOptions and fix build/ta…
Pull changes from parent repository
Signed-off-by: Iltotore <[email protected]>
Yes. Paths can be capricious between operating systems. Maybe this test and change should be applied to the oslib. |
@Iltotore Are you going to create a PR for oslib? |
If you think it is better than pushing changes here, yes. |
|
It's a misbehavior there and should be fixed there. |
…buildTarget/dependencySources - cannot import into IDE There is a PR already (com-lihaoyi#1092) but I am wary of dealing with Strings directly. Here is my approach. On Windows, File URLs follow an peculiar representation in Java ``` scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL java.net.URL = file:/C:/Users/Developer/mill/./ ``` From this, we wish to get a `Path` back, and the way to do this is: ``` scala> java.nio.file.Paths.get((java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL).toURI) java.nio.file.Path = C:\Users\Developer\mill\. ``` Unit testing for this is more challenging because the `WindowsFileSystem` instance is a `sun.nio.fs` package, rather than a standard package. The solution here, compared to the previous code, is to reduce the number of conversions; the key loss happens when you do `(URL).getFile`. ``` scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL java.net.URL = file:/C:/Users/Developer/mill/./ scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL.getFile String = /C:/Users/Developer/mill/./ ```
…Sources - cannot import into IDE (#1285) There is a PR already (#1092) but I am wary of dealing with Strings directly. Here is my approach. On Windows, File URLs follow an peculiar representation in Java ``` scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL java.net.URL = file:/C:/Users/Developer/mill/./ ``` From this, we wish to get a `Path` back, and the way to do this is: ``` scala> java.nio.file.Paths.get((java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL).toURI) java.nio.file.Path = C:\Users\Developer\mill\. ``` Unit testing for this is more challenging because the `WindowsFileSystem` instance is a `sun.nio.fs` package, rather than a standard package. The solution here, compared to the previous code, is to reduce the number of conversions; the key loss happens when you do `(URL).getFile`. ``` scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL java.net.URL = file:/C:/Users/Developer/mill/./ scala> java.nio.file.Paths.get(".").toAbsolutePath.toUri.toURL.getFile String = /C:/Users/Developer/mill/./ ``` Pull request: #1285
|
Superseded by #1285 and also by upstream PR com-lihaoyi/os-lib#53. |
|
@Iltotore Thank you for your work on this topic! Although we fixed the issue now without any of your commits, your work is highly appreciated. |
URL#getFileinmill.bsp.ModuleUtils#getMillBuildClasspath, fixing [BSP] buildTarget/javacOptions not found #1091 and [BSP] InvalidPathException on Windows #1021